twix/raylib
1
0
Fork 0
mirror of https://github.com/raysan5/raylib.git synced 2026-04-16 03:59:09 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix raycasting logic in models_basic_voxel.c (#5643)

Browse Source 
The original logic iterated through the world and broke at the first found voxel that intersected the ray. This broke in some cases, removing a voxel out of view. I changed the algorithm to track the closest found voxel, and remove it at the end of the loop if one was found.
This commit is contained in:
Thomas Prowse
2026-03-12 10:36:53 +00:00
committed by GitHub
parent 64e8bfcfb6
commit 8a93587eaa
1 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
examples/models/models_basic_voxel.c
View File

@ -72,6 +72,7 @@ int main(void)
UpdateCamera(&camera, CAMERA_FIRST_PERSON); UpdateCamera(&camera, CAMERA_FIRST_PERSON);
// Handle voxel removal with mouse click // Handle voxel removal with mouse click
// This method is quite inefficient. Ray marching through the voxel grid using DDA would be faster, but more complex.
if (IsMouseButtonPressed(MOUSE_LEFT_BUTTON)) if (IsMouseButtonPressed(MOUSE_LEFT_BUTTON))
{ {
// Cast a ray from the screen center (where crosshair would be) // Cast a ray from the screen center (where crosshair would be)
@ -79,12 +80,14 @@ int main(void)
Ray ray = GetMouseRay(screenCenter, camera); Ray ray = GetMouseRay(screenCenter, camera);
// Check ray collision with all voxels // Check ray collision with all voxels
bool voxelRemoved = false; float closestDistance = 99999.0f;
for (int x = 0; (x < WORLD_SIZE) && !voxelRemoved; x++) Vector3 closestVoxelPosition = { -1, -1, -1 };
bool voxelFound = false;
for (int x = 0; x < WORLD_SIZE; x++)
{ {
for (int y = 0; (y < WORLD_SIZE) && !voxelRemoved; y++) for (int y = 0; y < WORLD_SIZE; y++)
{ {
for (int z = 0; (z < WORLD_SIZE) && !voxelRemoved; z++) for (int z = 0; z < WORLD_SIZE; z++)
{ {
if (!voxels[x][y][z]) continue; // Skip empty voxels if (!voxels[x][y][z]) continue; // Skip empty voxels
@ -97,14 +100,23 @@ int main(void)
// Check ray-box collision // Check ray-box collision
RayCollision collision = GetRayCollisionBox(ray, box); RayCollision collision = GetRayCollisionBox(ray, box);
if (collision.hit) if (collision.hit && (collision.distance < closestDistance))
{ {
voxels[x][y][z] = false; // Remove this voxel closestDistance = collision.distance;
voxelRemoved = true; // Exit all loops closestVoxelPosition = (Vector3){ x, y, z };
voxelFound = true;
} }
} }
} }
} }
// Remove the closest voxel if one was hit
if (voxelFound)
{
voxels[(int)closestVoxelPosition.x]
[(int)closestVoxelPosition.y]
[(int)closestVoxelPosition.z] = false;
}
} }
//---------------------------------------------------------------------------------- //----------------------------------------------------------------------------------