twix/raylib
1
0
Fork 0
mirror of https://github.com/raysan5/raylib.git synced 2026-08-24 21:28:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Compare commits

base: twix:12259324492d71cc6b90a5104d1eed3e46914547
Branches Tags
twix:master twix:patch-1
twix:6.0 twix:5.5 twix:5.0 twix:4.6-dev twix:4.5.0 twix:4.2.0 twix:4.0.0 twix:3.7.0 twix:3.5.0 twix:3.0.0 twix:2.6.0 twix:2.5.0 twix:2.0.0 twix:1.9.7-dev twix:1.9.4-dev twix:1.8.0 twix:1.7.0 twix:1.6.0 twix:1.5.0 twix:1.4.0 twix:1.3.0 twix:1.2.2 twix:1.1.1 twix:1.0.6 twix:1.0.4
...
compare: twix:d46a59367ffc56b5f86133dafbdfd3d979da3903
Branches Tags
twix:master twix:patch-1
twix:6.0 twix:5.5 twix:5.0 twix:4.6-dev twix:4.5.0 twix:4.2.0 twix:4.0.0 twix:3.7.0 twix:3.5.0 twix:3.0.0 twix:2.6.0 twix:2.5.0 twix:2.0.0 twix:1.9.7-dev twix:1.9.4-dev twix:1.8.0 twix:1.7.0 twix:1.6.0 twix:1.5.0 twix:1.4.0 twix:1.3.0 twix:1.2.2 twix:1.1.1 twix:1.0.6 twix:1.0.4

2 Commits
1225932449 ... d46a59367f

Author SHA1 Message Date
yoobezxc
d46a59367f [msbuild] MSVC x64 build compatibility support (#6052) (#6053) 
Change EnableEnhancedInstructionSet to NotSet for compatibility old hardware.
 2026-08-11 21:14:47 +02:00
Federico Andres
868413839a Fix glTF pose sampled at the end of an animation returning a pose from the start (#6048) 
GetPoseAtTimeGLTF searches for the interval containing the requested time
with (tstart <= time) && (time < tend). A time equal to the last keyframe
satisfies no interval, so the loop ends without a match and keyframe stays
at its 0 default, making the function return a pose from the beginning of
the animation.

LoadModelAnimationsGLTF samples at t = j/60 for j in [0, keyframeCount),
with keyframeCount = (int)(duration*60) + 1, so the last sample lands
exactly on the end of the animation whenever duration*60 is a whole
number. The last pose of those clips is wrong, which looks like a jerk
right before the animation ends.

Measured on a glTF with a 0.85 s clip: the delta between the last two
poses was 23x the median delta between consecutive poses; with this
change it is 0.3x, in line with every other step.
 2026-08-11 21:13:19 +02:00
2 changed files with 18 additions and 1 deletions
Expand all files Collapse all files

2
projects/VS2022/raylib/raylib.vcxproj
View File

@ -357,7 +357,7 @@
<AdditionalIncludeDirectories>$(ProjectDir)..\..\..\src\external\glfw\include</AdditionalIncludeDirectories>
<CompileAs>CompileAsC</CompileAs>
<DebugInformationFormat />
<EnableEnhancedInstructionSet>AdvancedVectorExtensions2</EnableEnhancedInstructionSet>
<EnableEnhancedInstructionSet>NotSet</EnableEnhancedInstructionSet>
</ClCompile>
<Link>
<SubSystem>Windows</SubSystem>

17
src/rmodels.c
View File

@ -6390,6 +6390,7 @@ static bool GetPoseAtTimeGLTF(cgltf_interpolation_type interpolationType, cgltf_
float tstart = 0.0f;
float tend = 0.0f;
int keyframe = 0; // Defaults to first pose
bool found = false;
for (int i = 0; i < (int)input->count - 1; i++)
{
@ -6402,10 +6403,26 @@ static bool GetPoseAtTimeGLTF(cgltf_interpolation_type interpolationType, cgltf_
if ((tstart <= time) && (time < tend))
{
keyframe = i;
found = true;
break;
}
}
// No interval contains a time at (or past) the last keyframe, because the
// search above requires time < tend: clamp to the edge interval instead of
// falling back to keyframe 0, which returns a pose from the start
if (!found && ((int)input->count >= 2))
{
keyframe = (int)input->count - 2;
float tfirst = 0.0f;
if (!cgltf_accessor_read_float(input, 0, &tfirst, 1)) return false;
if (time < tfirst) keyframe = 0;
if (!cgltf_accessor_read_float(input, keyframe, &tstart, 1)) return false;
if (!cgltf_accessor_read_float(input, keyframe + 1, &tend, 1)) return false;
}
// Constant animation, no need to interpolate
if (FloatEquals(tend, tstart))
{